[PATCH v6 2/5] rust: pci: provide access to PCI Vendor values

John Hubbard jhubbard at nvidia.com
Tue Aug 26 20:58:51 UTC 2025


On 8/26/25 1:45 PM, Danilo Krummrich wrote:
> On 8/26/25 10:38 PM, John Hubbard wrote:
>> On 8/25/25 5:47 AM, Danilo Krummrich wrote:
>>> On Mon Aug 25, 2025 at 2:33 PM CEST, Alexandre Courbot wrote:
>> ...
> Sorry, that's on me being not precise. When I said private I meant private to
> the parent module.
> 
> The diff looks good, thanks!

Huge relief! :)

> 
> Please also make sure to add #[inline] where appropriate and rebase onto
> driver-core-next.

I have no idea "where appropriate" is, here. These are not hot paths, and
the existing pci.rs methods such as Device::vendor_id() are not inlined,
and so my initial approach is to just not inline any of this...

thanks,
-- 
John Hubbard



More information about the Nouveau mailing list