[PATCH v2 2/5] rust: macros: extend custom `quote!()` macro

Benno Lossin lossin at kernel.org
Thu Aug 28 07:14:14 UTC 2025


On Thu Aug 28, 2025 at 8:39 AM CEST, Alice Ryhl wrote:
> On Fri, Aug 15, 2025 at 7:32 AM Jesung Yang <y.j3ms.n at gmail.com> wrote:
>> +    (@proc $v:ident $span:ident == $($tt:tt)*) => {
>> +        $v.push(::proc_macro::TokenTree::Punct(
>> +                ::proc_macro::Punct::new('=', ::proc_macro::Spacing::Joint)
>> +        ));
>> +        $v.push(::proc_macro::TokenTree::Punct(
>> +                ::proc_macro::Punct::new('=', ::proc_macro::Spacing::Alone)
>> +        ));
>> +        quote_spanned!(@proc $v $span $($tt)*);
>
> Not a blocker, but if the way to implement this one is to push =
> twice, then I think the pattern should just be a single = and then you
> push a = once. The pattern can match twice to handle ==.

You can't do that, since the first one needs the `Joint` spacing and the
second one the `Alone` one. `==` also is a single token in macro input,
so matching only on `=` doesn't work.

---
Cheers,
Benno


More information about the Nouveau mailing list