[PATCH 1/2] gpu: nova-core: add initial driver stub

John Hubbard jhubbard at nvidia.com
Sat Feb 1 04:13:19 UTC 2025


On 1/31/25 8:01 PM, John Hubbard wrote:
> On 1/31/25 2:04 PM, Danilo Krummrich wrote:
...
>> +        let bar = pdev.iomap_region_sized::<BAR0_SIZE>(0, c_str!("nova-core"))?;
> 

Oh, one more thing about naming, since this is going to set a pattern:
let's consider changing:

     "NovaCore"
to:
     "nova_core" (or nova-core, whatever)

Because that's how the rest of the module naming works in the kernel.
Even the Rust samples do it. And NovaCore just adds a pointless obstacle
in finding things such as /sys/module/nova_core, etc etc.

I understand that many Rust-for-Linux things are new and different, and
it's a judgment call on which ones should be. So this is my suggested
judgment call, after looking around at this (and also after spending time
with Dave's out of tree nova-core, for a few days/weeks as well).


thanks,
-- 
John Hubbard



More information about the Nouveau mailing list