[PATCH] drm/nouveau: select FW caching

[Luis Chamberlain]

On Tue, Feb 18, 2025 at 06:24:43PM +0100, Danilo Krummrich wrote:
> On Tue, Feb 18, 2025 at 06:28:53AM -0800, Luis Chamberlain wrote:
> > 
> > What I recommend is to look into why we disable it by default, I think
> 
> I think FW_CACHE is enabled by default, no?
> 
> > its sold old obscure reasoning but now suspect it was udev being dumb,
> > in line with why we also try to defensively try to ignore duplicate
> > udev requests for module requests causing a flood. Refer to commit
> > 9b9879fc03275ff ("modules: catch concurrent module loads, treat them as
> > idempotent") for details.
> 
> Thanks, that helps a lot.
> 
> Given that this commit landed in v6.5

That commit lets us ignore the udev floods for superfluous module
requests only.

> I guess there's not really a concern to
> force enable FW_CACHE for Nouveau as a fix for commit 176fdcbddfd2
> ("drm/nouveau/gsp/r535: add support for booting GSP-RM"), which landed in v6.7.

I'd recommmend to look into *why* folks didn't like fw cache to look at
disabling it in the first place, and look and see if udev was acting up
and doing stupid things preventing suspend.

 Luis