[RFC PATCH 0/3] gpu: nova-core: add basic timer subdevice implementation
Danilo Krummrich
dakr at kernel.org
Thu Feb 27 17:32:15 UTC 2025
On Thu, Feb 27, 2025 at 08:55:09AM -0800, Boqun Feng wrote:
> On Thu, Feb 27, 2025 at 12:17:33PM -0400, Jason Gunthorpe wrote:
>
> > I still wonder why you couldn't also have these reliable reference
> > counts rooted on the device driver instead of only on the module.
> >
>
> You could put reliable reference counts anywhere you want, as long as it
> reflects the resource dependencies.
Right, as I explained in a different reply, the signature for PCI driver probe()
looks like this:
fn probe(pdev: &mut pci::Device, _info: &Self::IdInfo) -> Result<Pin<KBox<Self>>>
The returned Pin<KBox<Self>> has the lifetime of the driver being bound to the
device.
Which means a driver can bind things to this lifetime. But, it isn't forced to,
it can also put things into an Arc and share it with the rest of the world.
If something is crucial to be bound to the lifetime of a driver being bound to a
device (i.e. device resources), you have to expose it as Devres<T>.
Subsequently, you can put the Devres<T> in an Arc and do whatever you want, the
result will still be that T is dropped once the device is unbound.
More information about the Nouveau
mailing list