[RFC 2/8] drm/nouveau: introduce tu102_gsp_init_fw_heap()

[Zhi Wang]

On 22/11/2024 18.26, Timur Tabi wrote:
> On Fri, 2024-11-22 at 04:57 -0800, Zhi Wang wrote:
>> +int
>> +tu102_gsp_init_fw_heap(struct nvkm_gsp *gsp)
>> +{
>> +	nvkm_gsp_init_fw_heap(gsp);
>> +
>> +	return 0;
>> +}
>> +
>>   static int
>>   tu102_gsp_fwsec_load_bld(struct nvkm_falcon_fw *fw)
>>   {
>> @@ -171,6 +179,7 @@ tu102_gsp_r535_113_01 = {
>>   
>>   	.wpr_heap.base_size = 8 << 20,
>>   	.wpr_heap.min_size = 64 << 20,
>> +	.wpr_heap.init_fw_heap = tu102_gsp_init_fw_heap,
>>   
> 
> Why not just
> 
> 	.wpr_heap.init_fw_heap = nvkm_gsp_init_fw_heap,
> 
> 
NVKM seems following a C++ inhering principles in callbacks. I am 
leaning towards to follow it until we figured out a scheme. E.g. 
programming guide docs to follow.

Z.