<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [NVAC] Trying to register nv_backlight after NV96 did it"
href="https://bugs.freedesktop.org/show_bug.cgi?id=86539#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [NVAC] Trying to register nv_backlight after NV96 did it"
href="https://bugs.freedesktop.org/show_bug.cgi?id=86539">bug 86539</a>
from <span class="vcard"><a class="email" href="mailto:jwrdegoede@fedoraproject.org" title="Hans de Goede <jwrdegoede@fedoraproject.org>"> <span class="fn">Hans de Goede</span></a>
</span></b>
<pre>Hi Pierre,
Thanks for working on this. I'm not sure what the nbs suffix stands for, maybe
rename it to
bl_interface_nr ?
Chances are that nv50_backlight_init() may run twice at the same time if 2
cards are being probed simultaneously. So I would make bl_interface_nr an
atomic_t and use:
int nr = atomic_inc_return(&bl_interface_nr) - 1;
to increment it and get the _NEW_ value. Since this gives you the new value,
you should substract 1 as is done above.
Regards,
Hans</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>