<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Kernel unaligned access at TPC[105d9fb4] nvkm_instobj_wr32+0x14/0x20 [nouveau]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=96836#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Kernel unaligned access at TPC[105d9fb4] nvkm_instobj_wr32+0x14/0x20 [nouveau]"
href="https://bugs.freedesktop.org/show_bug.cgi?id=96836">bug 96836</a>
from <span class="vcard"><a class="email" href="mailto:ciaran.gillespie@gmail.com" title="Kieron Gillespie <ciaran.gillespie@gmail.com>"> <span class="fn">Kieron Gillespie</span></a>
</span></b>
<pre>(In reply to Ilia Mirkin from <a href="show_bug.cgi?id=96836#c15">comment #15</a>)
<span class="quote">> (In reply to Ilia Mirkin from <a href="show_bug.cgi?id=96836#c14">comment #14</a>)
> > OK, well let's start small. One source of problems is that we have
> >
> > drivers/gpu/drm/nouveau/nouveau_bios.h:#define ROM16(x) le16_to_cpu(*(u16
> > *)&(x))
> >
> > Which can only work on aligned pointers x, but it gets called with unaligned
> > offsets in nouveau_bios.c
> >
> > Can you try changing that to
> >
> > #define ROM16(x) get_unaligned_le16(&(x))
> >
> > I'm guessing that will help with the first group of unaligned traps.
>
> Oh, and same treatment for ROM32 of course (and ROM64 while you're at it,
> but that never gets called from what I can tell).</span >
Alright I'll give that a shot and let you know, thanks for the help!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>