<html><body><div>Any comments? I also think for developers, it's good to be able to see from someone's dmesg output whether or not external firmware was loaded. Unless there is some other way to do that without this log message?</div><div><br data-mce-bogus="1"></div><div>-- Dan</div><div><br>On Sep 17, 2016, at 02:04 AM, Dan Moulding <dmoulding@me.com> wrote:<br><br></div><div><blockquote type="cite"><div class="msg-quote"><div class="_stretch"><span class="body-text-content">In previous versions, it used to log an info message when loading<br>external GR firmware. But that info message was (inadvertently?)<br>removed in commit 18cd5bc. This just adds it back. It's nice for users<br>to be able to confirm whether external firmware was loaded or not.<br><br>Signed-off-by: Dan Moulding <dmoulding@me.com><br>---<br> drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 1 +<br> 1 file changed, 1 insertion(+)<br><br>diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c<br>index ae9ab5b..0ed56ff 100644<br>--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c<br>+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c<br>@@ -1805,6 +1805,7 @@ gf100_gr_new_(const struct gf100_gr_func *func, struct nvkm_device *device,<br> return ret;<br> <br> if (gr->firmware) {<br>+ nvkm_info(&gr->base.engine.subdev, "using external firmware\n");<br> if (gf100_gr_ctor_fw(gr, "fecs_inst", &gr->fuc409c) ||<br> gf100_gr_ctor_fw(gr, "fecs_data", &gr->fuc409d) ||<br> gf100_gr_ctor_fw(gr, "gpccs_inst", &gr->fuc41ac) ||<br>-- <br>2.7.3<br><br></span></div></div></blockquote></div></body></html>