<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Stuttering video playback in totem after update to 1.19-rc1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98030#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Stuttering video playback in totem after update to 1.19-rc1"
href="https://bugs.freedesktop.org/show_bug.cgi?id=98030">bug 98030</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>The change in 8f1edf4bd3a1f050ce9eeb5eac45dd1a8f7a6d5e is that we no longer
wakeup and flush writers when space in the write queue becomes available -
instead before we poll() we flush the writers iff NewOutputPending since the
last poll(), i.e.
diff --git a/os/WaitFor.c b/os/WaitFor.c
index 8164c30..5b0c342 100644
--- a/os/WaitFor.c
+++ b/os/WaitFor.c
@@ -207,8 +207,7 @@ WaitForSomething(Bool are_ready)
(1000000 / MILLI_PER_SECOND);
wt = &waittime;
}
- if (NewOutputPending)
- FlushAllOutput();
+ FlushAllOutput();
/* keep this check close to select() call to minimize race */
if (dispatchException)
i = -1;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>