<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 23 October 2016 at 01:32, Karol Herbst <span dir="ltr"><<a href="mailto:karolherbst@gmail.com" target="_blank">karolherbst@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I think it would be better to squash those commits:<br>
1. for the includes<br>
2. for static declerations<br>
<div><div class="gmail-h5"><br></div></div></blockquote><div>OK, I have resent new patch that squash those commits.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="gmail-h5">
2016-10-22 11:41 GMT+02:00 Baoyou Xie <<a href="mailto:baoyou.xie@linaro.org">baoyou.xie@linaro.org</a>>:<br>
> We get 2 warnings when building kernel with W=1:<br>
> drivers/gpu/drm/nouveau/nvkm/<wbr>core/firmware.c:34:1: warning: no previous prototype for 'nvkm_firmware_get' [-Wmissing-prototypes]<br>
> drivers/gpu/drm/nouveau/nvkm/<wbr>core/firmware.c:58:1: warning: no previous prototype for 'nvkm_firmware_put' [-Wmissing-prototypes]<br>
><br>
> In fact, these functions are declared in<br>
> drivers/gpu/drm/nouveau/<wbr>include/nvkm/core/firmware.h.<br>
> So this patch adds missing header dependencies.<br>
><br>
> Signed-off-by: Baoyou Xie <<a href="mailto:baoyou.xie@linaro.org">baoyou.xie@linaro.org</a>><br>
> ---<br>
>  drivers/gpu/drm/nouveau/nvkm/<wbr>core/firmware.c | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/drivers/gpu/drm/nouveau/<wbr>nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/<wbr>nvkm/core/firmware.c<br>
> index 34ecd4a..058ff46 100644<br>
> --- a/drivers/gpu/drm/nouveau/<wbr>nvkm/core/firmware.c<br>
> +++ b/drivers/gpu/drm/nouveau/<wbr>nvkm/core/firmware.c<br>
> @@ -20,6 +20,7 @@<br>
>   * DEALINGS IN THE SOFTWARE.<br>
>   */<br>
>  #include <core/device.h><br>
> +#include <core/firmware.h><br>
><br>
>  /**<br>
>   * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory<br>
> --<br>
> 2.7.4<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> Nouveau mailing list<br>
> <a href="mailto:Nouveau@lists.freedesktop.org">Nouveau@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/nouveau" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/nouveau</a><br>
</blockquote></div><br></div></div>