<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">Op za 29 okt. 2016 om 01:40 schreef Peter Wu <<a href="mailto:peter@lekensteyn.nl">peter@lekensteyn.nl</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Check whether the kernel really supports power resources for a device,<br class="gmail_msg">
otherwise the power might not be removed when the device is runtime<br class="gmail_msg">
suspended (DSM should still work in these cases where PR does not).<br class="gmail_msg">
<br class="gmail_msg">
Link: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=98398" rel="noreferrer" class="gmail_msg" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=98398</a><br class="gmail_msg">
Fixes: 692a17dcc292 ("drm/nouveau/acpi: fix lockup with PCIe runtime PM")<br class="gmail_msg">
Signed-off-by: Peter Wu <<a href="mailto:peter@lekensteyn.nl" class="gmail_msg" target="_blank">peter@lekensteyn.nl</a>><br class="gmail_msg">
---<br class="gmail_msg">
Hi,<br class="gmail_msg">
<br class="gmail_msg">
Maybe Cc: stable (4.8+)?<br class="gmail_msg">
<br class="gmail_msg">
Compile-tested only. Rick, can you test if this patch fixes the problem for you?<br class="gmail_msg">
<br class="gmail_msg">
This check was actually in the original patch, but it was changed:<br class="gmail_msg">
<a href="https://lists.freedesktop.org/archives/nouveau/2016-May/025125.html" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/archives/nouveau/2016-May/025125.html</a><br class="gmail_msg">
Re-adding the check as suggested by Mika.<br class="gmail_msg">
<br class="gmail_msg">
Kind regards,<br class="gmail_msg">
Peter<br class="gmail_msg">
---<br class="gmail_msg">
drivers/gpu/drm/nouveau/nouveau_acpi.c | 3 ++-<br class="gmail_msg">
1 file changed, 2 insertions(+), 1 deletion(-)<br class="gmail_msg">
<br class="gmail_msg">
diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c b/drivers/gpu/drm/nouveau/nouveau_acpi.c<br class="gmail_msg">
index dc57b62..193573d 100644<br class="gmail_msg">
--- a/drivers/gpu/drm/nouveau/nouveau_acpi.c<br class="gmail_msg">
+++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c<br class="gmail_msg">
@@ -240,7 +240,8 @@ static bool nouveau_pr3_present(struct pci_dev *pdev)<br class="gmail_msg">
if (!parent_adev)<br class="gmail_msg">
return false;<br class="gmail_msg">
<br class="gmail_msg">
- return acpi_has_method(parent_adev->handle, "_PR3");<br class="gmail_msg">
+ return parent_adev->power.flags.power_resources &&<br class="gmail_msg">
+ acpi_has_method(parent_adev->handle, "_PR3");<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
static void nouveau_dsm_pci_probe(struct pci_dev *pdev, acpi_handle *dhandle_out,<br class="gmail_msg">
--<br class="gmail_msg">
2.10.1<br class="gmail_msg">
<br class="gmail_msg"></blockquote><div>Hi Peter,</div><div><br></div><div>This patch indeed does fix the issue for me, thank you.</div><div><br></div><div>Kind regards,</div><div>Rick</div><div><br></div><div>Tested-by: Rick Kerkhof <<a href="mailto:rick.2889@gmail.com">rick.2889@gmail.com</a>></div></div></div>