<div dir="ltr"><div dir="ltr">On Fri, 12 Jul 2019 at 00:42, Mark Menzynski <<a href="mailto:mmenzyns@redhat.com">mmenzyns@redhat.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Mark Menzynski <<a href="mailto:mmenzyns@redhat.com" target="_blank">mmenzyns@redhat.com</a>><br></blockquote><div><br></div><div>In addition to the general comments I provided to this patch series, you should add a prefix before ":" to the first line of</div><div>this commit message:</div><div><br></div><div>Maybe something like "drm/nouveau/bios/gpio: sort gpio function names by value"<br></div><div><br></div><div>You can see the general approach with:</div><div><br></div><div> $ git log -n10 --oneline drivers/gpu/drm/nouveau/include/nvkm/subdev/bios/gpio.h</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> ---<br> drm/nouveau/include/nvkm/subdev/bios/gpio.h | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drm/nouveau/include/nvkm/subdev/bios/gpio.h b/drm/nouveau/include/nvkm/subdev/bios/gpio.h<br> index b71a3555..2f40935f 100644<br> --- a/drm/nouveau/include/nvkm/subdev/bios/gpio.h<br> +++ b/drm/nouveau/include/nvkm/subdev/bios/gpio.h<br> @@ -3,9 +3,9 @@<br> #define __NVBIOS_GPIO_H__<br> enum dcb_gpio_func_name {<br> DCB_GPIO_PANEL_POWER = 0x01,<br> + DCB_GPIO_FAN = 0x09,<br> DCB_GPIO_TVDAC0 = 0x0c,<br> DCB_GPIO_TVDAC1 = 0x2d,<br> - DCB_GPIO_FAN = 0x09,<br> DCB_GPIO_FAN_SENSE = 0x3d,<br> DCB_GPIO_LOGO_LED_PWM = 0x84,<br> DCB_GPIO_UNUSED = 0xff,<br> -- <br> 2.21.0<br> <br> _______________________________________________<br> Nouveau mailing list<br> <a href="mailto:Nouveau@lists.freedesktop.org" target="_blank">Nouveau@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/nouveau" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/nouveau</a></blockquote></div></div>