<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div>On Tue, 2023-11-07 at 19:11 +0100, Danilo Krummrich wrote:</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>I think the problem already starts with gf100_bar_new_() not setting its<br>
</div>
<div>pbar argument to NULL on failure, but this code assuming that.<br>
</div>
</blockquote>
<div><br>
</div>
<div>
<div><span style="font-size: 14.666667px;">Isn't it standard procedure for functions not to write to output parameters on failure? </span></div>
</div>
<div><br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>Generally, I think it would be better if all those functions would return<br>
</div>
<div>an ERR_PTR on failure.<br>
</div>
</blockquote>
<div><br>
</div>
<div>Agreed.</div>
<div><span></span></div>
</body>
</html>