<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div>On Mon, 2024-06-17 at 19:48 +0200, Danilo Krummrich wrote:</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<pre>+ mem->size = size;</pre>
<pre>+ mem->dev = gsp->subdev.device->dev;</pre>
</blockquote>
<pre><br></pre>
<pre>If this can potentially out-live the drivers remove() callback, we have to take</pre>
<pre>a device reference here and drop it in nvkm_gsp_mem_dtor().</pre>
<pre><br></pre>
<pre> mem->dev = get_device(gsp->subdev.device->dev);</pre>
</blockquote>
<div><br>
</div>
<div>That's an excellent idea, thanks. It's not currently a problem, but like you said, the idea is to allow it.</div>
<div><br>
</div>
<div><span></span></div>
</body>
</html>