[Ocs] Attica patches

[Frederik Gladhorn]

Hi Laszlo,

you reverted the binary incompatible commit, thanks.

If we really want a more restful api, I think that is a big make-over of the 
ocs api. Then we need to go down the V2 route of the plugin interface. I am a 
bit unsure how that would work with supporting both versions. The other option 
might be to create a new major version of attica at some point and not be 
backwards compatible.

Cheers,
Frederik




On Thursday 7. April 2011 22.21.33 Papp Laszlo (EXT-Symbio/Helsinki) wrote:
> Hi Frederik,
> 
> OK, thank you.
> 
> I think I got a bit lost now with this issue. :p The problem is that
> kdeplatformdependent will not support the new OCS specific features that
> we would like to have, which means that the "internal" qtplatformdependent
> code can have more features than the kde-attica version then. I do not
> know any way how to make new features available for both class,
> qt/kdeplatformdependent attica code.
> 
> In an abstract, generic way about this issue: There is a Qt support library
> (whatever), there is a KDE interface for that. If anything is needed to be
> added to the base class and that is not a QObject, it can go haywire, I
> hope I am just wrong and there is an easy way to fix such an issue.
> 
> https://projects.kde.org/projects/kdesupport/attica/repository/revisions/73
> 8bcc334ecdc0f434d853736ed97b120864f194/diff/lib/platformdependent.h -> I
> wanted to add put/delete method support to the base class, to extent the
> post/get method support there. It would be nice if it could be done, but
> not sure how the kdeplatformdependent class could pick this feature up as
> well, if I just make a new MyClassV2 way.
> 
> Best Regards,
> Laszlo Papp
> ________________________________________
> From: Frederik Gladhorn [frederik.gladhorn at nokia.com]
> Sent: Wednesday, April 06, 2011 11:15 AM
> To: Papp Laszlo (EXT-Symbio/Helsinki)
> Subject: Re: Attica patches
> 
> Hi Laszlo,
> 
> sounds good to me, just commit and I'll review for real before a release.
> Please keep binary compatibility in mind and create beautiful apis :)
> I don't want to be the blocker for you guys.
> 
> Greetings,
> Frederik
> 
> On Wednesday 6. April 2011 06.18.55 Papp Laszlo (EXT-Symbio/Helsinki) wrote:
> > Hi Frederik,
> > 
> > I am sending the git formatted version of the Achievement, Forum patches.
> > The achievement  was reviewed by Dan and Shantanu from the Gluon team.
> > 
> > Is that fine with you if we commit the trivial Gluon related changes
> > after our own internal Gluon team review. We could integrate the patches
> > faster then and you should not be fast with the responses, but you could
> > take a look at the commit anytime when you are available. (CCMAIL is
> > also possible to you). We need to refactor some thing after the OCS 2.0
> > sprint we are just organizing, anyway. :) Mateu Batle Sastre could also
> > help sometimes with the patches for making sure, they are fine.
> > 
> > Would that be fine with you ?
> > 
> > Best Regards,
> > Laszlo Papp