[Ocs] Review Request: attica crash is vote is > 100
Frederik Gladhorn
gladhorn at kde.org
Mon Jan 3 11:24:20 PST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100290/#review711
-----------------------------------------------------------
I'm okay with the change, but please add a qWarning so this does not go by completely unnoticed.
- Frederik
On 2011-01-03 09:43:53, Nicolas Lécureuil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100290/
> -----------------------------------------------------------
>
> (Updated 2011-01-03 09:43:53)
>
>
> Review request for Attica.
>
>
> Summary
> -------
>
> it seems that in kde-look sometimes ( by errors ) some votes can be > to 100.
>
> My idea is to set rating to 100 if it is > to 100.
>
>
> This addresses bug 261530.
> http://bugs.kde.org/show_bug.cgi?id=261530
>
>
> Diffs
> -----
>
> lib/provider.cpp d9298a7
>
> Diff: http://git.reviewboard.kde.org/r/100290/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nicolas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20110103/dadf9790/attachment.htm>
More information about the Ocs
mailing list