[Ocs] Review Request: attica crash is vote is > 100

[Frederik Gladhorn]

> On 2011-01-03 19:24:21, Frederik Gladhorn wrote:
> > I'm okay with the change, but please add a qWarning so this does not go by completely unnoticed.
> 
> Nicolas Lécureuil wrote:
>     is: 
>     
>     qWarning() << "Rating is superior to 100, fallback to 100." ;
>     
>     ok for you ?
> 
> Nicolas Lécureuil wrote:
>     i commited : http://bugs.kde.org/show_bug.cgi?id=261530#c3

Thanks for your effort.
I think "larger than 100" would have been a better wording since "superior" means something like better.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100290/#review711
-----------------------------------------------------------


On 2011-01-03 09:43:53, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100290/
> -----------------------------------------------------------
> 
> (Updated 2011-01-03 09:43:53)
> 
> 
> Review request for Attica.
> 
> 
> Summary
> -------
> 
> it seems that in kde-look sometimes ( by errors ) some votes can be > to 100.
> 
> My idea is to set rating to 100 if it is > to 100.
> 
> 
> This addresses bug 261530.
>     http://bugs.kde.org/show_bug.cgi?id=261530
> 
> 
> Diffs
> -----
> 
>   lib/provider.cpp d9298a7 
> 
> Diff: http://git.reviewboard.kde.org/r/100290/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20110104/3aea3352/attachment.htm>