[Ocs] Review Request: Added static build option
Constantin-Alexandru Tudorica
tudalex at gmail.com
Fri Jul 8 23:23:39 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101880/#review4540
-----------------------------------------------------------
lib/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101880/#comment3951>
1) The "client" word was allready there. I modified the other headers to reference the new file (without "client" in it).
2) I thought it will mess out of source builds but apparently it has no such effect. Sorry, bad testing on my part.
- Constantin-Alexandru
On July 8, 2011, 6:51 p.m., Constantin-Alexandru Tudorica wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101880/
> -----------------------------------------------------------
>
> (Updated July 8, 2011, 6:51 p.m.)
>
>
> Review request for Attica and Patrick Spendrin.
>
>
> Summary
> -------
>
> Added static build options for libattica.
>
>
> Diffs
> -----
>
> CMakeLists.txt d45455a
> lib/CMakeLists.txt a04167f
> lib/atticaclient_export.h bb2e6f1
> lib/atticaclient_export.h.cmake PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101880/diff
>
>
> Testing
> -------
>
> Did a successful build on windows using mingw32 and also linked successfully to the static library.
>
>
> Thanks,
>
> Constantin-Alexandru
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20110709/d7ae46a2/attachment.html>
More information about the Ocs
mailing list