[Ocs] Review Request: Added static build option

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101880/#review4546
-----------------------------------------------------------

Ship it!


Good catch with the last since version.h also works that way for a reason. I do not have time right now to test it on Linux and Windows at least. If you say it is fine for those platforms as expected, then please push it. Thank you for improving attica! =)

- Laszlo


On July 9, 2011, 9:03 a.m., Constantin-Alexandru Tudorica wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101880/
> -----------------------------------------------------------
> 
> (Updated July 9, 2011, 9:03 a.m.)
> 
> 
> Review request for Attica and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> Added static build options for libattica.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d45455a 
>   lib/CMakeLists.txt a04167f 
>   lib/atticaclient_export.h bb2e6f1 
>   lib/atticaclient_export.h.cmake PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101880/diff
> 
> 
> Testing
> -------
> 
> Did a successful build on windows using mingw32 and also linked successfully to the static library. 
> 
> 
> Thanks,
> 
> Constantin-Alexandru
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20110709/e13fd41d/attachment.htm>