[Ocs] Review Request: group || over &&. clang warning

Frederik Gladhorn gladhorn at kde.org
Sun Jun 3 00:40:46 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105129/#review14387
-----------------------------------------------------------

Ship it!


Ship It!

- Frederik Gladhorn


On June 1, 2012, 5:29 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105129/
> -----------------------------------------------------------
> 
> (Updated June 1, 2012, 5:29 p.m.)
> 
> 
> Review request for Attica.
> 
> 
> Description
> -------
> 
> following clang advise.
> the || and && must be grouped this way or the other way.
> 
> 
> Diffs
> -----
> 
>   lib/buildserviceparser.cpp 82ca18e 
>   lib/publisherparser.cpp ad8afe7 
> 
> Diff: http://git.reviewboard.kde.org/r/105129/diff/
> 
> 
> Testing
> -------
> 
> warning disappear.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20120603/3a7d2656/attachment.htm>


More information about the Ocs mailing list