[ooo-build-bugs] [Bug 30556] New: [Patch] Convert all virtual functions QueryValue() and PutValue() to return bool instead of a mix of BOOL and sal_Bool

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30556

           Summary: [Patch] Convert all virtual functions QueryValue() and
                    PutValue() to return bool instead of a mix of BOOL and
                    sal_Bool
           Product: LibreOffice
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: low
         Component: libreoffice
        AssignedTo: ooo-build-bugs at lists.freedesktop.org
        ReportedBy: nthiebaud at gmail.com


Created an attachment (id=39112)
 View: https://bugs.freedesktop.org/attachment.cgi?id=39112
 Review: https://bugs.freedesktop.org/review?bug=30556&attachment=39112

patch to convert QueryValue() and PutValue() virtual funcitons to bool

The patch is very large (almost 1M), because both BOOL and sal_Bool are defined
as unsigned char, and of course bool is... a boolean.
The C++ compiler doesn't like a virtual funciton declared as returning a
unsigned char and re-implemented returnuing a bool.
So it is an all or nothing operation.

the only way to do that is phase would be:

1/ introduce a new typedef TBOOL as unsigned char
2/ do many small patchs to migrate the BOOL and sal_BOOL impacted by this patch
to TBOOL
3/ a patch to change the typedef of TBOOL to bool
4/ another series of patch to change TBOOL to bool
5/ remove the TBOOL typdedef

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.