[ooo-build-commit] .: sc/source

Kohei Yoshida kohei at kemper.freedesktop.org
Tue Oct 5 18:11:52 PDT 2010


 sc/source/filter/excel/xilink.cxx |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 13d88caf87ba995c0559418229f7b512dd035653
Author: Kohei Yoshida <kyoshida at novell.com>
Date:   Tue Oct 5 21:09:34 2010 -0400

    Better performance on Excel doc import.
    
    Don't set cached range on every single cell import when loading
    Excel document with external ref cache.  This would become a major
    performance bottleneck with a document with large cache.

diff --git a/sc/source/filter/excel/xilink.cxx b/sc/source/filter/excel/xilink.cxx
index 65b4e9a..406bc01 100644
--- a/sc/source/filter/excel/xilink.cxx
+++ b/sc/source/filter/excel/xilink.cxx
@@ -404,28 +404,28 @@ void XclImpSupbookTab::LoadCachedValues(ScExternalRefCache::TableTypeRef pCacheT
             {
                 bool b = p->GetBool();
                 ScExternalRefCache::TokenRef pToken(new formula::FormulaDoubleToken(b ? 1.0 : 0.0));
-                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken);
+                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken, 0, false);
             }
             break;
             case EXC_CACHEDVAL_DOUBLE:
             {
                 double f = p->GetValue();
                 ScExternalRefCache::TokenRef pToken(new formula::FormulaDoubleToken(f));
-                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken);
+                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken, 0, false);
             }
             break;
             case EXC_CACHEDVAL_ERROR:
             {
                 double fError = XclTools::ErrorToDouble( p->GetXclError() );
                 ScExternalRefCache::TokenRef pToken(new formula::FormulaDoubleToken(fError));
-                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken);
+                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken, 0, false);
             }
             break;
             case EXC_CACHEDVAL_STRING:
             {
                 const String& rStr = p->GetString();
                 ScExternalRefCache::TokenRef pToken(new formula::FormulaStringToken(rStr));
-                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken);
+                pCacheTable->setCell(rAddr.mnCol, rAddr.mnRow, pToken, 0, false);
             }
             break;
             default:


More information about the ooo-build-commit mailing list