[ooo-build] kde4 filepicker bug

[Shtylman]

I have not done any work on combining the loops and really wouldn't  
know where to start from the OO side. As kendy said combining would  
probly be the best solution for the long term.

Short term: there is the qt even loop handler in the vlc plugin (don't  
know which file off the top of my head) but if you put a redraw call  
in there to redrAw the main OO window that should fix it.

Interestingly enough, I run kwin with compositing and this bug does  
Not happen and everything appears to work normally.

Rafael, please do let me know if you can work out the checkbox bug in  
the file picker... It has bothered me for some time and I never could  
find a fix for it.

P.S. Avoid the seperate thread/kde3 filepicker approach as it will  
cause more headache than it is worth, trust me ... There was a reason  
I went away from it for kde4 filepicker and my sanity was a  
consideration :)

~Roman

On Aug 11, 2009, at 3:38 AM, Jan Holesovsky <kendy at suse.cz> wrote:

> Hi Rafael,
>
> On Monday 10 of August 2009, Rafael Cabral wrote:
>
>> I'm working to fixes some ooo 3.1 kde4 filepicker. One of them  
>> seems to
>> be a redraw bug since if you try drag the filepicker it leaves many
>> footprints around ooo window (see attached). I think it could be a
>> design bug mainly because of this snipet on KDE4FilePicker.cxx code:
>>
>> sal_Int16 SAL_CALL KDE4FilePicker::execute()
>>    throw( uno::RuntimeException )
>> {
>> ...
>> //nasty hack to get a local qt event loop going to process the dialog
>> ///otherwise the dialog returns immediately
>> while (_dialog->isVisible())
>> {
>>   kapp->processEvents(QEventLoop::WaitForMoreEvents);
>> }
>> ...
>>
>> So I was reading kde3 filepicker source code and I've thought we  
>> could
>> solve that drag bug by running the picker in a separated thread in  
>> a way
>> similar you did with the kde3 version.
>>
>> What do you think ? some idea ?
>
> Let me add the Roman, who did most of the porting, and Philipp, who  
> recently
> up-streamed that.   Also adding the ooo-build@ mailing list, as  
> there are
> some KDE4-interested people there too.
>
> And to the problem - to have the correct solution, we need the Qt  
> event loop
> and the OOo event loop combined.  That is necessary not only for the
> filepicker, but also for the systray integration (not done now, but  
> would be
> great to have that at some stage).  Most probably, the event loops  
> have not
> been combined yet - Roman, Philipp, did you do any work on this  
> recently,
> please?
>
> And wrt. the more threads, no, I think we don't really want to do it  
> that way,
> it would make things much more complicated; I can imagine lots of  
> nasty
> issues when one of the event loops runs in one thread, and the other  
> in other
> thread [if it worked at all ;-)].
>
> Regards,
> Kendy