[ooo-build] [go-oo.org Dev] CRLF line endings
Bjoern Michaelsen
Bjoern.Michaelsen at Sun.COM
Tue Jun 9 01:39:12 PDT 2009
Jens-Heiner Rechtien wrote:
> Martin Hollmichel wrote:
>> any reason why ?
>
> Not on principle, just because of the overriding per log message
> mechanism. The same guys who can't be bothered to do a diff before
> committing will almost certainly use the overriding mechanism without a
> second thought.
> The problem is that the overriding mechanism would be needed to often,
> mostly because of the check for tabs. Without that one a python
> implementation of that script might be acceptable though I would do
> things differently.
My hope was that becoming "the guy that always gets the tabs wrong"
might be enough of an embarrassment to keep that from happening. Maybe I
am a bit naive.
> The script would also at least need to discern between commits done for
> rebasing and others. You'll almost always have an exceptional file in
> every rebase and people will be annoyed if their scripted rebase fails
> due to such checks.
True.
> The other thing is I have to check first if bzr, git or mercurial have a
> similar mechanism. Once these things are in place people get so used to
> it they can't live without it any longer. Might sound stupid but it is a
> fact of live ... I learned that the hard way.
bzr, git and mercurial cannot do that in the way svn does by definition.
With those you commit locally and thus commits are out of the control of
RelEng. However:
- Formatting can easily be checked when a cws is nominated
(and wont be integrated unless cleaned up)
- Commits to tags/trunk/whatever shouldnt be possible with DSCM as the
repos holding those should be owned by RelEng and be readonly for the
rest of the world(*). Anyone unhappy with the way RelEng handles their
repos will be easily able to clone and pull from those, so this is not
at all "less open".
> But: Do you really want RE impose such stupid things on you? I rather
> don't want to police things. If really a majority of the developers want
> that RE polices your commits ... well, I've got a number of ideas there
> ... :-)
Things that are easily checked (like certain formatting issues) should
be. Tabs and linebreaks should be reliably checkable. What other
policies do you have in mind? ;-)
Have Fun,
Björn
(*) Rest of the world is anyone not in RelEng including app devs at sun etc.
--
===========================================================================
Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551
Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schröder,Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering
===========================================================================
_______________________________________________
Dev mailing list
Dev at lists.go-oo.org
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org
More information about the ooo-build
mailing list