[ooo-build] [go-oo.org Dev] CRLF line endings

[Jens-Heiner Rechtien]

Martin Hollmichel wrote:
> Bjoern Michaelsen wrote:
>> Thorsten Behrens wrote:
>>> Martin Hollmichel wrote:
>>>> at least this is not my understanding. yes, it was a bad hack to
>>>> modify  a CVS client to make sure that this does not happen in the
>>>> Hamburg  environment. I think a precommit check is much more clean
>>>> and transparent,
>>> cool - then, why not start with what Bjoern proposed here:
>>> http://www.openoffice.org/servlets/ReadMsg?list=dev&msgNo=23533
>>>
>>> (I especially like the check for tabs ;))
>> Just a small additional info: RelEng told me they use python only on
>> the server side. It would be easy to rewrite that as a python script,
>> but as RelEng said "we wouldnt use it anyway", I didnt.
> any reason why ?

Not on principle, just because of the overriding per log message
mechanism. The same guys who can't be bothered to do a diff before
committing will almost certainly use the overriding mechanism without a
second thought.

The problem is that the overriding mechanism would be needed to often,
mostly because of the check for tabs.  Without that one a python
implementation of that script might be acceptable though I would do
things differently.

The script would also at least need to discern between commits done for
rebasing and others. You'll almost always have an exceptional file in
every rebase and people will be annoyed if their scripted rebase fails
due to such checks.

The other thing is I have to check first if bzr, git or mercurial have a
similar mechanism. Once these things are in place people get so used to
it they can't live without it any longer. Might sound stupid but it is a
fact of live ... I learned that the hard way.

But: Do you really want RE impose such stupid things on you? I rather
don't want to police things. If really a majority of the developers want
that RE polices your commits ... well, I've got a number of ideas there
... :-)

Heiner

-- 
Jens-Heiner Rechtien
rechtien at sun.com
_______________________________________________
Dev mailing list
Dev at lists.go-oo.org
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org