[ooo-build] OXYGEN_IMAGES_TAR vs !OxygenOffice build

[Petr Mladek]

Hi Miklos,

On Thursday 25 June 2009, Miklos Vajna wrote:
> Hi Petr and KAMI,
>
> First I had an issue:
>
> 11:31 < vmiklos> _KAMI_: hmm, got a build error with master, i guess it'll
> be realted to you :) 11:31 < vmiklos> dmake:  Error: --
>          
> `/var/tmp/fst/src/ooo-build-3.1/build/ooo310-m11/external_images/ooo_oxygen
>_images.tar.gz' not found, and can't be made
> 11:31 < vmiklos> maybe one of your patches don't have the "if oxygenoffice"
> guards?

I expect that you already know this. Oxygen is the default KDE4 theme => it is 
not related to OxygenOffice but it it related to the KDE4 integration.

> Then I saw commit f64e78c4ba5e715b05e32815e4b132e809182d4d from Petr,
> and I thought that'll solve my problem. I updated to
> e2e2e908e8fc02050b086a645eeccd4fb80be7a3, and now I get the same error.

I did the bad expectation (Oxygen == OxygenOffice) as well. Then people 
expained the mistake to me ;-)

> Then I read the git history and saw the "fix" I saw was actually
> reverted.
>
> My question: Then is it possible that the build wants to access
> ooo_oxygen_images.tar.gz, even if i use --disable-kde4 (when the
> download/unpack of this tarball is disabled)?
>
> In this case I think this issue is still not fixed, as the
> --disable-kde4 build is problematic. ;-)

The problem is that the icon theme is not optional. It is added by 
ooo-build/patches/dev300/kde4-oxygen-icons.diff. It is always applied in 
ooo-build master now. Yes, it would be possible to make it optional but... 
Note that the other icon themes are not optional as well (Industrial=GNOME, 
Crystal=KDE3).


-- 
Best Regards,

Petr Mladek
software developer
---------------------------------------------------------------------  
SUSE LINUX, s. r. o.                        e-mail: pmladek at suse.cz
Lihovarská 1060/12                          tel: +420 284 028 952
190 00 Prague 9                             fax: +420 284 028 951
Czech Republic                              http://www.suse.cz/