[ooo-build] apply script is going crazy on master

[Fridrich Strba]

AFAIK, the perl script just adds sections to a list without checking whether there are duplicates and then works through the list. Maybe there would be a solution by making it smart enough to eliminate duplicates. Like that it would not try to apply a section twice.

Cheers

Fridrich

>>> Petr Mladek <pmladek at suse.cz> 01/10/2009 11:52 >>>
On Thursday 01 October 2009, Kohei Yoshida wrote:
> On Wed, 2009-09-30 at 21:07 -0400, Kohei Yoshida wrote:
> > Two things strike me as odd.  First, why the apply script go back up in
> > the apply file, and second, why apply patches under BFBuildBits section,
> > which AFAIK no distros use.
>
> Well, I chatted with Tor a bit in IRC, and found out that there are
> several special sections that automatically get applied *after* all the
> other normal patches get applied, and the Binfilter sections
> (BFBuildBits, BFFixes, and BFShrink) are just one of those special
> sections.  And they can be anywhere in the apply file, and still get
> applied at the end...

These sections are applied via the extra --distro options, see 
ooo-build/bin/applyflags. The distros are proceed one by one by apply.pl. It 
would need to change the design to fix this.

Another possibility would be to apply these extra sections via 
the --additional-sections option.

The --distro options are used from histrical reasons 
because --additional-sections was implemented later. Any volunteer who would 
swith it it ;-)


Best Regards,
Petr
_______________________________________________
ooo-build mailing list
ooo-build at lists.freedesktop.org 
http://lists.freedesktop.org/mailman/listinfo/ooo-build