[ooo-build] [PATCH] Fix --whitout-split
Jan Holesovsky
kendy at suse.cz
Tue Sep 1 09:25:52 PDT 2009
Hi Rail,
On Monday 31 of August 2009, Rail Aliev wrote:
> JH> This is actually not correct, it breaks ./download script when
> JH> no --with-split/--without-split is provided.
> Ah, I haven't tested it in this particular situation
>
> JH> I suppose the right fix is in configure.in, to actually make it
> JH> empty when it is 'no' :-)
>
> …or use the following snippet:
> if ('@SPLIT@' eq '' || '@SPLIT@' eq 'no')…
>
> Which one do you prefer?
I prefer the configure.in change, because in the latter, I suppose you should
also check for the other occurrences of @SPLIT@/$SPLIT out there, so that we
are sure that everything works in the explicit 'no' case.
BTW, I suppose it is time to create the push access for you, as promised
before ;-) Can you please go through the steps on
http://www.freedesktop.org/wiki/Software/ooo-build/AccountRequestCheatSheet ?
Thank you,
Kendy
More information about the ooo-build
mailing list