[ooo-build] ANNOUNCE: ooo-build-3.2.98.1 released (3.3-alpha1)

[Gökçen Eraslan]

17 Eylül 2010 Cuma günü (saat 17:59:57) Petr Mladek şunları yazmıştı:
> Grr, the new scrip was not added to the released tarball. Please put the
> attached file into the ooo-build-3.2.98.1 directory. Make sure that it
> is executable:
>      
>      chmod 755 download_external_sources.sh
> 
> and run ./download again.
> 
> 
> I am sorry for the troubles. I will make sure that it is included in the
> next release.

I didn't check this version, but in previous versions of ooo-build, if a file 
could not be downloaded by download script (because of losing network 
connection for example), it was silently ignoring it. Later during the build, 
when you end up with a build error, it may be hard to understand which file is 
missing. 

As a solution why don't you define your own system() function in download 
sctript and check the return value of it every time it's called? So you can 
raise an exception if any of the commands fail, stop the download script 
immediately and print an error message about it (this is like 'set -e' command 
in a shell script). And we can see the file cannot be downloaded and re-
execute the download script if necessary.

This also make people think that all commands executed are really necessary, 
and should not be silently ignored.

-- 
Gökçen Eraslan
Pardus Developer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/ooo-build/attachments/20100918/12364d0d/attachment.pgp>