[Openchrome-devel] Bug in 2d initialization

[Xavier Bachelot]

Bartosz Kosiorek wrote:
> Hello.
> I found a bug in accel.c file (VIAInitialize2DEngine function).
> For example in VIA driver the registers initialization was from
> register 0x04 to 0x40.
> In Openchrome is:
> 
> for (i = 0x04; i < 0x40; i += 4) {
>         VIASETREG(i, 0x0);
>     }
> 
> I changed it to
> 
> for (i = 0x04; i <= 0x40; i += 4) {
>         VIASETREG(i, 0x0);
>     }
> 
> Best Regards
> Bartosz Kosiorek
> 
Hi Bartosz,

Well spotted. Also, according to the doc from VIA 
(http://www.x.org/docs/via/OGPM_UniChrome_ProII_R108a_Part1_Core_2D.pdf 
page 65, the Unichrome Pro group A 2D registers are also using the range 
from 0x44 to 0x6c. Not sure if and how this is handled in the current code.

@ all devs, Bartosz has already provided a few good patches, time to 
give him commits right ?

Regards,
Xavier