[Openchrome-devel] [PATCH] Add basic VX855 support to Openchrome

[Harald Welte]

Hi Xavier,

thanks for your review.

On Fri, May 22, 2009 at 06:52:24PM +0200, Xavier Bachelot wrote:

> >> Index: trunk/src/via_mode.h
> >> ===================================================================
> >> --- trunk/src/via_mode.h	(revision 747)
> >> +++ trunk/src/via_mode.h	(working copy)
> >> @@ -44,49 +44,55 @@
> >>      int DotClock;
> >>      CARD16 UniChrome;
> >>      CARD32 UniChromePro;
> >> +    CARD32 Chrome9HC;
> > 
> > Isn't the VX855 Chrome9HCM ?
> > Chrome9HC is the P4M900, iirc, and P4M900 is using the unichromePro
> > dotclock table.

yes, it's HCM

> >> Index: trunk/src/via_bandwidth.c
> >> ===================================================================
> >> --- trunk/src/via_bandwidth.c	(revision 747)
> >> +++ trunk/src/via_bandwidth.c	(working copy)
> >> @@ -239,6 +239,7 @@
> >>              hwp->writeSeq(hwp, 0x22, 0x1F);
> >>              break;
> >>          case VIA_VX800:
> >> +        case VIA_VX855:
> >>              hwp->writeSeq(hwp, 0x16, 0x26); /* 152/4   = 38 */
> >>              hwp->writeSeq(hwp, 0x17, 0x5F); /* 192/2-1 = 95 */
> >>              hwp->writeSeq(hwp, 0x18, 0x26); /* 152/4   = 38 */ 
> > Are you sure this is right ? According to what is in viafb and the
> > values you defined in src/via.h below, it should be something like that :

yes, you are correct, this is a copy+paste mistake (i thought too low fifo
values can hardly hurt) but never fixed that later.

> > src/via_driver.c lacks an entry in the libpciaccess case, around line 128 :
> > VIA_DEVICE_MATCH (PCI_CHIP_VT3409, 0 ),

ok, thanks.

> > Also, still in the same file the condition is reverted.

ok, sorry about that.

> > In src/via_swov.c, around line 1271, PCI_CHIP_VT3409 is missing.
> > 
> > In srv/via_accel.c, around line 1292, pVia->Chipset != VIA_VX855 is missing.
> > 
> > In src/via_xvmc.c, around line 322, pVia->Chipset == VIA_VX855 is missing.

well, haven't even tried to start using any of those features...

> Please find attached an updated patch, including bits for my comments above.

thanks, I'll test this tomorrow when I'm at the VIA Office again, where I have
a VX855 reference board.

Cheers,
-- 
- Harald Welte <HaraldWelte at viatech.com>	    http://linux.via.com.tw/
============================================================================
VIA Open Source Liaison