[Openchrome-devel] [PATCH] Fix new modesetting on P4M890

Rafał Miłecki zajec5
Sun Sep 20 14:48:25 PDT 2009


W dniu 18 wrze?nia 2009 17:26 u?ytkownik Xavier Bachelot
<xavier at bachelot.org> napisa?:
>> Ups, sorry. I've read your mail when didn't have access to machine.
>> And forgot :|
>>
>> After applying your patch, changing resolution again causes lockup.
>> Tried this only once so far, will try later.
>>
>> Sorry again, I'm too busy with so many projects :/
>>
> No problem, I understand. I hope you don't mind the revert, but it's
> breaking X for a lot of people, so I think it's better to keep it out
> for now. I'm attaching another patch that can probably help. It seems
> some registers have been moved around in later revision of the chips. I
> would be glad if you can give it a try.

Sure, and sorry for posting patch that caused problems. We should have
test that better, but it's hard with that quite small community around
this driver :(

The patch you attached fixes issue on my P4M890. I've performed really
crazy operations with that and it seems to be really stable. Many
xrandr -s operations, Diablo II starting and even VT switching for
sure. My GPU didn't lock up.

So if you test this patch and won't find problem, would be nice to commit it.

Well, maybe you could just prefix all chipsets used in this patch with
"VIA_" string :) That would be much better to have driver that
compiles ;)

-- 
Rafa?




More information about the Openchrome-devel mailing list