[Openchrome-devel] [Bug 54063] XV video output does not work with S3 UniChrome Pro

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54063

--- Comment #20 from Bartosz Kosiorek <gang65 at poczta.onet.pl> 2012-09-08 15:33:40 UTC ---
Great news.
To fix this issue you have to modify viaSetColorSpace function.
Your chipset ID is PCI_CHIP_VT3259.

Replace following code:
void
viaSetColorSpace(VIAPtr pVia, int hue, int saturation, int brightness,
                 int contrast, Bool reset)
{
    CARD32 col1, col2;

    viaCalculateVideoColor(pVia, hue, saturation, brightness, contrast, reset,
                           &col1, &col2);
    switch (pVia->ChipId) {
        case PCI_CHIP_VT3205:
        case PCI_CHIP_VT3204:
        case PCI_CHIP_VT3259:
        case PCI_CHIP_VT3314:
            VIASETREG(V3_ColorSpaceReg_1, col1);
            VIASETREG(V3_ColorSpaceReg_2, col2);
            DBG_DD(ErrorF("000002C4 %08lx\n", col1));
            DBG_DD(ErrorF("000002C8 %08lx\n", col2));
            break;
        case PCI_CHIP_VT3327:
        case PCI_CHIP_VT3336:
        case PCI_CHIP_VT3324:

with:

void
viaSetColorSpace(VIAPtr pVia, int hue, int saturation, int brightness,
                 int contrast, Bool reset)
{
    CARD32 col1, col2;

    viaCalculateVideoColor(pVia, hue, saturation, brightness, contrast, reset,
                           &col1, &col2);
    switch (pVia->ChipId) {
        case PCI_CHIP_VT3205:
        case PCI_CHIP_VT3204:
        case PCI_CHIP_VT3314:
            VIASETREG(V3_ColorSpaceReg_1, col1);
            VIASETREG(V3_ColorSpaceReg_2, col2);
            DBG_DD(ErrorF("000002C4 %08lx\n", col1));
            DBG_DD(ErrorF("000002C8 %08lx\n", col2));
            break;
        case PCI_CHIP_VT3259:
        case PCI_CHIP_VT3327:
        case PCI_CHIP_VT3336:
        case PCI_CHIP_VT3324:

(In reply to comment #18)
> Created attachment 66846 [details]
> Wrong colors when forcing video output on LCD screen
> 
> SOME RELATIVE GOOD NEWS :
> =========================
> 
> In the ViaInitVideoStatusFlag function (src/via_xv_overlay.c), I have replaced
> :
> 
> static unsigned long
> ViaInitVideoStatusFlag(VIAPtr pVia)
> {
>     switch (pVia->ChipId) {
>         case PCI_CHIP_VT3205:
>         case PCI_CHIP_VT3204:
>         case PCI_CHIP_VT3259:
>         case PCI_CHIP_VT3314:
>             return VIDEO_HQV_INUSE | SW_USE_HQV | VIDEO_3_INUSE;
> 
> By :
> 
> static unsigned long
> ViaInitVideoStatusFlag(VIAPtr pVia)
> {
>     switch (pVia->ChipId) {
>         case PCI_CHIP_VT3205:
>         case PCI_CHIP_VT3204:
>         case PCI_CHIP_VT3259:
>         case PCI_CHIP_VT3314:
>             return VIDEO_HQV_INUSE | SW_USE_HQV | VIDEO_1_INUSE;
> 
> Now the XV video output is on the LCD screen but the colors are wrong. You will
> find in attachment a screenshot of the same video with X11 output and with XV
> output.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.