[Openchrome-devel] drm-openchrome: drivers/gpu/drm
James Simmons
jsimmons at kemper.freedesktop.org
Sat Jul 13 16:13:49 PDT 2013
drivers/gpu/drm/via/via_display.c | 8 --------
drivers/gpu/drm/via/via_hdmi.c | 8 --------
2 files changed, 16 deletions(-)
New commits:
commit 598e14c61be873f4496363fecc4f6cdff76ad949
Author: James Simmons <jsimmons at infradead.org>
Date: Sat Jul 13 16:43:54 2013 -0400
During the early days of this driver I develope a easy way to check if interlace or double scan was allowed. The mode_valid function is only call by drm_helper_probe_single_connector_modes which calls drm_mode_validate_flag that does what my code was doing. We can remove my checks.
diff --git a/drivers/gpu/drm/via/via_display.c b/drivers/gpu/drm/via/via_display.c
index a51ef1d..25f2f7e 100644
--- a/drivers/gpu/drm/via/via_display.c
+++ b/drivers/gpu/drm/via/via_display.c
@@ -305,14 +305,6 @@ int
via_connector_mode_valid(struct drm_connector *connector,
struct drm_display_mode *mode)
{
- if ((mode->flags & DRM_MODE_FLAG_INTERLACE) &&
- !connector->interlace_allowed)
- return MODE_NO_INTERLACE;
-
- if ((mode->flags & DRM_MODE_FLAG_DBLSCAN) &&
- !connector->doublescan_allowed)
- return MODE_NO_DBLESCAN;
-
/* Check Clock Range */
if (mode->clock > 400000)
return MODE_CLOCK_HIGH;
diff --git a/drivers/gpu/drm/via/via_hdmi.c b/drivers/gpu/drm/via/via_hdmi.c
index 7770a47..8afe533 100644
--- a/drivers/gpu/drm/via/via_hdmi.c
+++ b/drivers/gpu/drm/via/via_hdmi.c
@@ -613,14 +613,6 @@ static int
via_hdmi_mode_valid(struct drm_connector *connector,
struct drm_display_mode *mode)
{
- if ((mode->flags & DRM_MODE_FLAG_INTERLACE) &&
- !connector->interlace_allowed)
- return MODE_NO_INTERLACE;
-
- if ((mode->flags & DRM_MODE_FLAG_DBLSCAN) &&
- !connector->doublescan_allowed)
- return MODE_NO_DBLESCAN;
-
return MODE_OK;
}
More information about the Openchrome-devel
mailing list