[Openchrome-devel] [Bug 62112] New: xf86-video-openchrome doesn't work with xorg 1.14

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=62112

          Priority: medium
            Bug ID: 62112
          Assignee: openchrome-devel at lists.freedesktop.org
           Summary: xf86-video-openchrome doesn't work with xorg 1.14
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: bugs.freedesktop.org at hardfalcon.net
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: Driver/openchrome
           Product: xorg

xf86-video-openchrome doesn't work with xorg 1.14
because of the formerly deprecated function miInitializeBackingStore() being
used  in line 1876 of src/via_driver.c :

http://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_driver.c?id=a925749eb21ba9e2e58845bc91554a09f20322ca

miInitializeBackingStore() has been an empty function anyhow since november
2010, so the line in question can safely be removed:

http://cgit.freedesktop.org/xorg/xserver/commit/mi?id=c4c4676e6874b42c2371eee96faa2c2dbb59a704

I therefore propose the following patch:

diff -rup a/src/via_driver.c b/src/via_driver.c
--- a/src/via_driver.c    2013-03-10 16:11:57.614059200 +0100
+++ b/src/via_driver.c    2013-03-10 16:12:46.374062244 +0100
@@ -1873,7 +1873,6 @@ VIAScreenInit(SCREEN_INIT_ARGS_DECL)
     if (!pVia->NoAccel && !viaInitExa(pScreen))
         return FALSE;

-    miInitializeBackingStore(pScreen);
     xf86SetBackingStore(pScreen);
 #if 0
     xf86SetSilkenMouse(pScreen);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/openchrome-devel/attachments/20130310/082ddb52/attachment.html>