[Openchrome-devel] [PATCH] RandR: permit output properties

Daniel Gnoutcheff daniel at gnoutcheff.name
Sat Dec 13 21:16:35 PST 2014


Make our implementation of xf86OutputFuncsRec->set_output() return TRUE.

Implementations of this function are expected to return TRUE when given
a property that they don't recognize.  Otherwise, properties set by the
server core (e.g. EDID) will break.  (See commit 33133a1 in
xf86-video-intel.)

Since we don't support any properties ourselves,  we should always
return TRUE.

This is also needed to support clients that set custom output
properties; i.e. gnome-shell likes to set _MUTTER_PRESENTATION_OUTPUT,
and it works fine with other drivers but would crash with ValueError on
openchrome.
---
 src/via_outputs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/via_outputs.c b/src/via_outputs.c
index 0a23e81..1876937 100644
--- a/src/via_outputs.c
+++ b/src/via_outputs.c
@@ -166,7 +166,7 @@ static Bool
 via_tv_set_property(xf86OutputPtr output, Atom property,
 					RRPropertyValuePtr value)
 {
-    return FALSE;
+    return TRUE;
 }
 
 static Bool
@@ -505,7 +505,7 @@ static Bool
 via_dp_set_property(xf86OutputPtr output, Atom property,
 						RRPropertyValuePtr value)
 {
-    return FALSE;
+    return TRUE;
 }
 
 static Bool
@@ -680,7 +680,7 @@ static Bool
 via_analog_set_property(xf86OutputPtr output, Atom property,
 						RRPropertyValuePtr value)
 {
-    return FALSE;
+    return TRUE;
 }
 
 static Bool
-- 
1.9.1



More information about the Openchrome-devel mailing list