[Openchrome-devel] xf86-video-openchrome: configure.ac src/via_sii164.c src/via_sii164.h

[Luc Verhaegen]

On Thu, Aug 25, 2016 at 12:22:11PM +0000, Kevin Brace wrote:
> --- /dev/null
> +++ b/src/via_sii164.c
> @@ -0,0 +1,505 @@
> +/*
> + * Copyright 2016 Kevin Brace
> + * Copyright 2016 The OpenChrome Project
> + *                [http://www.freedesktop.org/wiki/Openchrome]
> + * Copyright 2014 SHS SERVICES GmbH
> + *

May i suggest that you remove the SHS copyright and add mine instead?

https://cgit.freedesktop.org/~libv/xf86-video-unichrome/tree/src/via_sii16x.c

That's a lot of similarities, with ordering and naming being quite 
similar. Then, xf86I2CMaskByte definitely is my copyright.

I suggest that you also fix vt1632, or that you unify this like i did, 
10 years ago: 
https://cgit.freedesktop.org/~libv/xf86-video-unichrome/log/src/via_sii16x.c

If you are going to turn this into the unichrome driver with randr1.3 
support, then you better properly acknowledge the original author.

Luc Verhaegen.