[Openchrome-devel] [Bug 94473] DRM / KMS bootup error on VX900 platform

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94473

--- Comment #50 from Kevin Brace <kevinbrace at gmx.com> ---
Hi Frank,

I reviewed the patch and rewrote the patch comment section somewhat.
I will not do this every time you create a patch.
That being said, I think there is a general guideline somewhere that
freedesktop.org wants the characters per line to be capped below 80, and I
think about 72 is probably better cosmetically.
It is merely a formatting guideline, so each sentence does not have to be below
72 or 80 characters, obviously.
Another thing is that the H1 / H2 in the original comment is VIA Technologies
terms for their DMA engine generation, and other than people who deal with
their hardware directly (i.e., VIA Technologies device driver group, you, and
I), the other DRM developers will have no idea what H1 or H2 is.
That's why I changed the naming to the actual product name like UniChrome
(their IGP) or P4M890 chipset, since those names are more known.
    Regarding your sign off section, I added a comma (",") between Huang and
Ran since in eastern Asian culture, surname (last name) is pronounced or
written before the given name (first name).
The comma is there to signify that Huang is your surname to those who may not
be aware.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/openchrome-devel/attachments/20160324/3cf841df/attachment.html>