[Openchrome-devel] [Bug 94473] DRM / KMS bootup error on VX900 platform

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=94473

--- Comment #55 from HuangRan <huangran at iscas.ac.cn> ---
Hi Kevin,

(In reply to Kevin Brace from comment #50)
> Hi Frank,
> 
> I reviewed the patch and rewrote the patch comment section somewhat.
> I will not do this every time you create a patch.
Never mind. Actually you helped me a lot on how to generate a formatted patch
to Linux community. I remember last time I committed to RADEON drm driver, it
is 3-4 years ago...So for some rules, I have forgotten them. Your new patch
looks better than mine.

> That being said, I think there is a general guideline somewhere that
> freedesktop.org wants the characters per line to be capped below 80, and I
> think about 72 is probably better cosmetically.
> It is merely a formatting guideline, so each sentence does not have to be
> below 72 or 80 characters, obviously.
I found a link for coding style as below link:
http://www.x.org/wiki/CodingStyle/
But it seems that it does not tell how a patch should look like.

> Another thing is that the H1 / H2 in the original comment is VIA
> Technologies terms for their DMA engine generation, and other than people
> who deal with their hardware directly (i.e., VIA Technologies device driver
> group, you, and I), the other DRM developers will have no idea what H1 or H2
> is.
> That's why I changed the naming to the actual product name like UniChrome
> (their IGP) or P4M890 chipset, since those names are more known.
I do agree with your point here. Let's use P4M890, VX800, and VX900 chipsets
instead of H1/H2.

>     Regarding your sign off section, I added a comma (",") between Huang and
> Ran since in eastern Asian culture, surname (last name) is pronounced or
> written before the given name (first name).
> The comma is there to signify that Huang is your surname to those who may
> not be aware.
Yup. Huang is my family name and Ran is my first name. It is okay to use a
comma between it.
Actually, in general case, when I replied in my mail, I prefer to use "Frank"
for my first name because I usually use it when I am in AMD where I use "Frank"
to communicate with western guys.
But for patch, I prefer to use "Huang, Ran".

Thanks,
Frank

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/openchrome-devel/attachments/20160324/69ffb9e1/attachment-0001.html>