[Openchrome-devel] drm-openchrome: 4 commits - drivers/gpu/drm

[Rafał Miłecki]

On 04/05/2017 03:53 AM, Kevin Brace wrote:
> diff --git a/drivers/gpu/drm/via/via_analog.c b/drivers/gpu/drm/via/via_analog.c
> index 1263201f977..47ae89766fa 100644
> --- a/drivers/gpu/drm/via/via_analog.c
> +++ b/drivers/gpu/drm/via/via_analog.c
> @@ -49,28 +49,31 @@ static const struct drm_encoder_funcs via_dac_enc_funcs = {
>  	.destroy = via_encoder_cleanup,
>  };
>
> -/* Manage the power state of the DAC */
> +/*
> + * Manage the power state of analog (VGA) DAC.
> + */
>  static void
> -via_dac_dpms(struct drm_encoder *encoder, int mode)
> +via_analog_dpms(struct drm_encoder *encoder, int mode)
>  {
> -	struct via_device *dev_priv = encoder->dev->dev_private;
> -	u8 mask = 0;
> -
> -	switch (mode) {
> -	case DRM_MODE_DPMS_SUSPEND:
> -		mask = BIT(5);		/* VSync off */
> -		break;
> -	case DRM_MODE_DPMS_STANDBY:
> -		mask = BIT(4);		/* HSync off */
> -		break;
> -	case DRM_MODE_DPMS_OFF:
> -		mask = (BIT(5) | BIT(4));/* HSync and VSync off */
> -		break;
> -	case DRM_MODE_DPMS_ON:
> -	default:
> -		break;
> -	}
> -	svga_wcrt_mask(VGABASE, 0x36, mask, BIT(5) | BIT(4));
> +    struct via_device *dev_priv = encoder->dev->dev_private;
> +
> +    DRM_DEBUG("Entered via_analog_dpms.\n");
> +
> +    switch (mode) {
> +    case DRM_MODE_DPMS_ON:
> +        viaAnalogOutput(dev_priv, true);
> +        break;
> +    case DRM_MODE_DPMS_SUSPEND:
> +    case DRM_MODE_DPMS_STANDBY:
> +    case DRM_MODE_DPMS_OFF:
> +        viaAnalogOutput(dev_priv, false);
> +        break;
> +    default:
> +        DRM_ERROR("Bad DPMS mode.");
> +        break;
> +    }
> +
> +    DRM_DEBUG("Exiting via_analog_dpms.\n");

Keeping kernel's CodingStyle:
1) Using tabs
2) Not using CamelCase
would avoid extra work if you ever decide to upstream this driver.

Also not changing blindly tabs to spaces on purpose would simplify your commits (diffs).