[Openchrome-devel] drm-openchrome: Branch 'drm-next-4.13' - drivers/gpu/drm

[Kevin Brace]

 drivers/gpu/drm/openchrome/via_fp.c |   40 ------------------------------------
 1 file changed, 40 deletions(-)

New commits:
commit ae0d9189ad93b6d89031d7ca887f5ba07f87714a
Author: Kevin Brace <kevinbrace at gmx.com>
Date:   Sat Aug 12 00:08:45 2017 -0700

    Removed dithering property from FP code
    
    The code was causing crashes during boot.
    
    Signed-off-by: Kevin Brace <kevinbrace at gmx.com>

diff --git a/drivers/gpu/drm/openchrome/via_fp.c b/drivers/gpu/drm/openchrome/via_fp.c
index 04928d67c43d..bbb0c3826061 100644
--- a/drivers/gpu/drm/openchrome/via_fp.c
+++ b/drivers/gpu/drm/openchrome/via_fp.c
@@ -797,13 +797,6 @@ via_lcd_detect(struct drm_connector *connector,  bool force)
 	return ret;
 }
 
-static const struct drm_prop_enum_list dithering_enum_list[] =
-{
-	{ DRM_MODE_DITHERING_OFF, "Off" },
-	{ DRM_MODE_DITHERING_ON, "On" },
-	{ DRM_MODE_DITHERING_AUTO, "Automatic" },
-};
-
 static int
 via_lcd_set_property(struct drm_connector *connector,
 			struct drm_property *property, uint64_t value)
@@ -835,27 +828,6 @@ via_lcd_set_property(struct drm_connector *connector,
 				return -EINVAL;
 			}
 		}
-
-		list_for_each_entry(prop, &con->props, head) {
-			if (property == prop) {
-				u8 reg_value;
-
-				switch (value) {
-				case DRM_MODE_DITHERING_AUTO:
-				case DRM_MODE_DITHERING_ON:
-					reg_value = BIT(0);
-					break;
-
-				case DRM_MODE_DITHERING_OFF:
-					reg_value = 0x00;
-					break;
-
-				default:
-					return -EINVAL;
-				}
-				svga_wcrt_mask(VGABASE, 0x88, reg_value, BIT(0));
-			}
-		}
 	}
 	return 0;
 }
@@ -1087,8 +1059,6 @@ via_lvds_init(struct drm_device *dev)
 {
 	struct via_device *dev_priv = dev->dev_private;
 	bool dual_channel = false, is_msb = false;
-	uint64_t dither = DRM_MODE_DITHERING_OFF;
-	struct drm_property *dithering;
 	struct via_connector *con;
 	struct via_encoder *enc;
 	struct edid *edid;
@@ -1152,8 +1122,6 @@ via_lvds_init(struct drm_device *dev)
 
 			DRM_DEBUG("panel index %x detected\n", reg_value);
 
-			if (reg_value < 0x0A)
-				dither = DRM_MODE_DITHERING_ON;
 		}
 	} else {
 		/* 00 LVDS1 + LVDS2  10 = Dual channel. Other are reserved */
@@ -1170,14 +1138,6 @@ via_lvds_init(struct drm_device *dev)
 					dev->mode_config.scaling_mode_property,
 					DRM_MODE_SCALE_CENTER);
 
-	dithering = drm_property_create_enum(dev, 0, "dithering",
-					     dithering_enum_list,
-					     ARRAY_SIZE(dithering_enum_list));
-	list_add(&dithering->head, &con->props);
-
-	drm_object_attach_property(&con->base.base, dithering, dither);
-	via_lcd_set_property(&con->base, dithering, dither);
-
 	/* Now setup the encoder */
 	drm_encoder_init(dev, &enc->base, &via_lvds_enc_funcs,
 						DRM_MODE_ENCODER_LVDS, NULL);