[openchrome-devel] drm-openchrome: Branch 'drm-next-5.2' - drivers/gpu/drm

[Kevin Brace]

Hi Luc,

Well, no wonder that portion of the code was relatively clean since the code James did were generally fairly messy.
Give me a day or two to examine your portion of the code, but at a first glance, you appear to be correct that he took your code without giving you credit.
Generally speaking, I do not rely on your past work, so I only learn about this when you point it out.
This is the second time this has happened (first time was the VT1632(A) DVI code, and James committed the buggy code into the repository), and if you wanted to, let me know if there are other portions that other people copied from your past work without attribution.
I will use "Suggested-by" to refer to you in the commit message, will this be okay?

Regards,

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com


> Sent: Tuesday, March 19, 2019 at 8:11 PM
> From: "Luc Verhaegen" <libv at skynet.be>
> To: "Kevin Brace" <kevinbrace at kemper.freedesktop.org>
> Cc: openchrome-devel at lists.freedesktop.org
> Subject: Re: [openchrome-devel] drm-openchrome: Branch 'drm-next-5.2' - drivers/gpu/drm
>
> On Tue, Mar 19, 2019 at 06:15:43PM +0000, Kevin Brace wrote:
> >  drivers/gpu/drm/openchrome/openchrome_drv.h  |    2
> >  drivers/gpu/drm/openchrome/openchrome_fb.c   |  884 -------------------------
> >  drivers/gpu/drm/openchrome/openchrome_init.c |  939 +++++++++++++++++++++++++++
> >  3 files changed, 940 insertions(+), 885 deletions(-)
> >
> > New commits:
> > commit fba2aa548c6ff9cadd3e3b3fa0e23447cdb07768
> > Author: Kevin Brace <kevinbrace at gmx.com>
> > Date:   Tue Mar 19 11:15:19 2019 -0700
> >
> >     drm/openchrome: Move VRAM size detection code
> >
> >     The code was transferred to openchrome_init.c since the code runs
> >     only once during initialization.
> >
> >     Signed-off-by: Kevin Brace <kevinbrace at gmx.com>
>
> You will find that James Simmons blatantly copied this code from
> https://cgit.freedesktop.org/~libv/xf86-video-unichrome/tree/src/via_host.c
>
> The copyright on that code is
> 	Copyright 2006-2009 Luc Verhaegen.
> On an MIT license.
>
> Via code never poked northbridge registers directly. This was all borne
> out of my coreboot work.
>
> Luc Verhaegen.
>