<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Segfault in xf86DestroyI2CDevRec" href="https://bugs.freedesktop.org/show_bug.cgi?id=93675#c19">Comment # 19</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Segfault in xf86DestroyI2CDevRec" href="https://bugs.freedesktop.org/show_bug.cgi?id=93675">bug 93675</a> from <a class="email" href="mailto:elyk03@gmail.com" title="Kyle Guinn <elyk03@gmail.com>"> Kyle Guinn</a> <pre>(In reply to Kevin Brace from <a href="show_bug.cgi?id=93675#c16">comment #16</a>) > Created <a href="attachment.cgi?id=121584" name="attach_121584" title="Fixing DVI detection code crash">attachment 121584</a> <a href="attachment.cgi?id=121584&action=edit" title="Fixing DVI detection code crash">[details]</a> <a href='page.cgi?id=splinter.html&bug=93675&attachment=121584'>[review]</a> [review] > Fixing DVI detection code crash > > The portion of the code responsible for detecting VT1632A external TMDS > transmitter for DVI was causing a crash if VT1632A was not detected on > I2C buses. This was happening due to xf86DestroyI2CDevRec being called > prior to the call to xf86I2CDevInit if VT1632A was not detected. Now the > code will probe I2C buses using xf86I2CProbeAddress to look for VT1632A, > and if VT1632A is not detected, it will stop trying to detect VT1632A > via I2C buses. > > Signed-off-by: Kevin Brace <<a href="mailto:kevinbrace@gmx.com">kevinbrace@gmx.com</a>> Looks good to me. I tried it out here and it works. Signed-off-by: Kyle Guinn <<a href="mailto:elyk03@gmail.com">elyk03@gmail.com</a>></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>