<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - DRM / KMS bootup error on VX900 platform" href="https://bugs.freedesktop.org/show_bug.cgi?id=94473#c39">Comment # 39</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - DRM / KMS bootup error on VX900 platform" href="https://bugs.freedesktop.org/show_bug.cgi?id=94473">bug 94473</a> from <a class="email" href="mailto:kevinbrace@gmx.com" title="Kevin Brace <kevinbrace@gmx.com>"> Kevin Brace</a> <pre>(In reply to HuangRan from <a href="show_bug.cgi?id=94473#c38">comment #38</a>) Hi Frank, > Hi Kevin, > > I just gave a try on my VX900 board. The KMS is working fine and > Xorg.0.log looks good with your proposal below: > ----------------------------------------------------------- > if ((dev_priv->engine_type <= VIA_ENG_H2) || > (dev->agp && drm_pci_device_is_agp(dev))) { > ----------------------------------------------------------- > Now that you have verified old H1/H2 chip and VX800 which is based on H5, > I do think we can commit this change to kernel. > For the first commit, I see your suggestion on <a href="show_bug.cgi?id=94473#c31">comment #31</a>, I think for > the first patch, I agree with that you do the commit with my name included. > And I prefer to know how to get the commit privilege for next step for > future commits in drm/ddx, so can you help me on that? Yup, I have seen some > discussion between you and other committer on how to do it, but if you can > send me a README for a more regular way to do a commit, it should be great. > > Thanks, > Frank > Frank, do you know how to create a patch using Git? If you don't, I can give you detailed instructions on how to do it. You can write a short description on how the patch will fix a bug we found in the code. After that, you can post the patch on dri-devel mailing list. <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a> There is a correct way to do this from Git, and again, I can give you instructions on how to do it, if you do not know how to do this. After that, I can do a commit of the code, assuming that my freedesktop.org commit privilege works in the first place for drm-openchrome repository. I say this because when I tried to do a commit for a different DDX project (xf86-video-r128) recently, I was not able to do a commit for that project. I presumably have to obtain an additional commit privilege to do a commit on that project.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>