<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - fix compilation after recent rename" href="https://bugs.freedesktop.org/show_bug.cgi?id=94660#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - fix compilation after recent rename" href="https://bugs.freedesktop.org/show_bug.cgi?id=94660">bug 94660</a> from <a class="email" href="mailto:kevinbrace@gmx.com" title="Kevin Brace <kevinbrace@gmx.com>"> Kevin Brace</a> <pre>(In reply to Benno Schulenberg from <a href="show_bug.cgi?id=94660#c0">comment #0</a>) Hi Benno, > Created <a href="attachment.cgi?id=122480" name="attach_122480" title="renames also the prototype">attachment 122480</a> <a href="attachment.cgi?id=122480&action=edit" title="renames also the prototype">[details]</a> <a href='page.cgi?id=splinter.html&bug=94660&attachment=122480'>[review]</a> [review] > renames also the prototype > > When renaming UnmapMem to UnmapMMIO it was forgotten to rename also the > prototype in the header file. Attached patch fixes that. > > However, with that fix I still cannot compile openchrome. (I have started > using -Werror, to not allow any warnings to slip by unnoticed: export > CFLAGS="-g -O2 -Werror" && ./configure && make clean all). > > via_ums.c: In functie ‘ums_create’: > via_ums.c:657:11: fout: impliciete declaratie van functie > ‘xf86InitFBManager’ [-Werror=implicit-function-declaration] > ret = xf86InitFBManager(pScreen, &AvailFBArea); > ^ > via_ums.c:668:9: fout: impliciete declaratie van functie > ‘xf86InitFBManagerLinear’ [-Werror=implicit-function-declaration] > xf86InitFBManagerLinear(pScreen, offset, size); > > It seems some xf86 header include is missing. Thank you very much for catching my error. Due to some development issues, I still do not use Eclipse IDE for the master branch code I work on (I am using gedit right now.). If I were using Eclipse IDE, I would have caught this mistake since it does have a powerful keyword search feature, and I would have used it. In the near future, I will likely integrate my master branch code with Eclipse IDE after I make a commit related to the rewrite of standby resume code. After that one, I will commit your fix with the following section added after your Signed-off-by line. Acked-by: Kevin Brace <<a href="mailto:kevinbrace@gmx.com">kevinbrace@gmx.com</a>> I hope that is okay.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>