<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - New build warnings" href="https://bugs.freedesktop.org/show_bug.cgi?id=96399#c6">Comment # 6</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - New build warnings" href="https://bugs.freedesktop.org/show_bug.cgi?id=96399">bug 96399</a> from <a class="email" href="mailto:kevinbrace@gmx.com" title="Kevin Brace <kevinbrace@gmx.com>"> Kevin Brace</a> <pre>(In reply to Xavier Bachelot from <a href="show_bug.cgi?id=96399#c4">comment #4</a>) > Hi Kevin, > > (In reply to Kevin Brace from <a href="show_bug.cgi?id=96399#c3">comment #3</a>) > > I hope the patch I uploaded fixes the compilation warning. > > I hope it fixes the warning. > > > Yes, the build warning (and bug) is gone. > I will commit the change shortly (I will push it within 24 hours.) > > > I though XAA has been removed from the X server ? > I know precious little about the BSDs, so I can't comment. I have seen a few remnants of XAA in the code. <a href="https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=25675f816326056eb9cd617f09d8dad23f1ae94a">https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=25675f816326056eb9cd617f09d8dad23f1ae94a</a> This stuff from the latest code. _____________________________________________________________ Bool umsCreate(ScrnInfoPtr pScrn) { ScreenPtr pScreen = pScrn->pScreen; VIAPtr pVia = VIAPTR(pScrn); unsigned long offset; BoxRec AvailFBArea; Bool ret = TRUE; long size; int maxY; #ifdef HAVE_DRI if (pVia->directRenderingType == DRI_1) { pVia->driSize = (pVia->FBFreeEnd - pVia->FBFreeStart) >> 2; if ((pVia->driSize > (pVia->maxDriSize * 1024)) && pVia->maxDriSize > 0) pVia->driSize = pVia->maxDriSize * 1024; /* In the case of DRI we handle all VRAM by the DRI ioctls */ if (pVia->useEXA) return TRUE; /* XAA has to use FBManager so we have to split the space with DRI */ maxY = pScrn->virtualY + (pVia->driSize / pVia->Bpl); } else #endif maxY = pVia->FBFreeEnd / pVia->Bpl; /* FBManager can't handle more than 32767 scan lines */ if (maxY > 32767) maxY = 32767; AvailFBArea.x1 = 0; AvailFBArea.y1 = 0; AvailFBArea.x2 = pScrn->displayWidth; AvailFBArea.y2 = maxY; pVia->FBFreeStart = (AvailFBArea.y2 + 1) * pVia->Bpl; /* * Initialization of the XFree86 framebuffer manager is done via * Bool xf86InitFBManager(ScreenPtr pScreen, BoxPtr FullBox) * FullBox represents the area of the framebuffer that the manager * is allowed to manage. This is typically a box with a width * of pScrn->displayWidth and a height of as many lines as can be fit * within the total video memory */ ret = xf86InitFBManager(pScreen, &AvailFBArea); if (ret != TRUE) xf86DrvMsg(pScrn->scrnIndex, X_ERROR, "xf86InitFBManager init failed\n"); DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Frame Buffer From (%d,%d) To (%d,%d)\n", AvailFBArea.x1, AvailFBArea.y1, AvailFBArea.x2, AvailFBArea.y2)); offset = (pVia->FBFreeStart + pVia->Bpp - 1) / pVia->Bpp; size = pVia->FBFreeEnd / pVia->Bpp - offset; if (size > 0) xf86InitFBManagerLinear(pScreen, offset, size); DEBUG(xf86DrvMsg(pScrn->scrnIndex, X_INFO, "Using %d lines for offscreen memory.\n", AvailFBArea.y2 - pScrn->virtualY)); return TRUE; } _____________________________________________________________ Since EXA is almost always used in Linux, it will not call xf86InitFBManager. We can fix this "flaw" later.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>