<div dir="ltr"><div>Hi</div>In attachment you have all warnings which was produced by using "-Wall" <div><br></div><div>We could always silent some types of warnings if we think it is not needed.</div><div> For example to silent all [-Wunused-variable] warnings:</div><div><br></div><div> -Werror -Wall -Wno-unused-variable</div><div><br></div><div>Best Regards</div><div>Bartosz</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-05 4:28 GMT+02:00 Bartosz <span dir="ltr"><<a href="mailto:gang65@wp.pl" target="_blank">gang65@wp.pl</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks Xavier.<div><br><div>It will be great to also enable "<span style="color:rgb(0,0,0);font-family:"Courier New";font-size:14px;line-height:20px;background-color:rgb(240,240,240)">-Wall" parameter.</span></div><div><a href="http://www.rapidtables.com/code/linux/gcc/gcc-wall.htm" target="_blank">http://www.rapidtables.com/<wbr>code/linux/gcc/gcc-wall.htm</a><br></div><div><a href="https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html" target="_blank">https://gcc.gnu.org/<wbr>onlinedocs/gcc/Warning-<wbr>Options.html</a><br></div><div><br></div><div><p style="color:rgb(0,0,0);font-family:"Times New Roman";font-size:medium"><samp><span>-Wall</span></samp> turns on the following warning flags:</p><pre style="color:rgb(0,0,0)"> -Waddress
-Warray-bounds=1 <span>(only with</span> <samp>-O2</samp><span>)</span>
-Wbool-compare
-Wc++11-compat -Wc++14-compat
-Wchar-subscripts
-Wcomment
-Wduplicate-decl-specifier <span>(C and Objective-C only)</span>
-Wenum-compare <span>(in C/ObjC; this is on by default in C++)</span>
-Wformat
-Wimplicit <span>(C and Objective-C only)</span>
-Wimplicit-int <span>(C and Objective-C only)</span>
-Wimplicit-function-<wbr>declaration <span>(C and Objective-C only)</span>
-Winit-self <span>(only for C++)</span>
-Wlogical-not-parentheses
-Wmain <span>(only for C/ObjC and unless</span> <samp>-ffreestanding</samp><span>)</span>
-Wmaybe-uninitialized
-Wmemset-elt-size
-Wmemset-transposed-args
-Wmisleading-indentation <span>(only for C/C++)</span>
-Wmissing-braces <span>(only for C/ObjC)</span>
-Wnarrowing <span>(only for C++)</span>
-Wnonnull
-Wnonnull-compare
-Wopenmp-simd
-Wparentheses
-Wpointer-sign
-Wreorder
-Wreturn-type
-Wsequence-point
-Wsign-compare <span>(only in C++)</span>
-Wsizeof-pointer-memaccess
-Wstrict-aliasing
-Wstrict-overflow=1
-Wswitch
-Wtautological-compare
-Wtrigraphs
-Wuninitialized
-Wunknown-pragmas
-Wunused-function
-Wunused-label
-Wunused-value
-Wunused-variable
-Wvolatile-register-var </pre></div><div><br></div><div class="gmail_extra">It will keep code cleaner, and will give you a message if something suspicious will happen.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Also there will be a lot of warnings which will need to be resolved.</div><div class="gmail_extra">Fortunately fixing warnings will be a good task for novice developer.</div><div class="gmail_extra"><br></div><div class="gmail_extra">What do you think about enabling "-Wall"?</div><div class="gmail_extra"><br></div><div class="gmail_extra">Best Regards</div><span class="HOEnZb"><font color="#888888"><div class="gmail_extra">Bartosz</div></font></span><div><div class="h5"><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-04 14:33 GMT+02:00 Xavier Bachelot <span dir="ltr"><<a href="mailto:xavier@bachelot.org" target="_blank">xavier@bachelot.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Signed-off-by: Xavier Bachelot <<a href="mailto:xavier@bachelot.org" target="_blank">xavier@bachelot.org</a>><br>
---<br>
I don't know my way through autotools very well, so not sure this is the best way, but it works...<br>
<br>
src/Makefile.am | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/Makefile.am b/src/Makefile.am<br>
index 82224d4..6ff7e31 100644<br>
--- a/src/Makefile.am<br>
+++ b/src/Makefile.am<br>
@@ -29,7 +29,7 @@ SUBDIRS = xvmc<br>
BUILT_SOURCES = version.h<br>
EXTRA_DIST = version.h<br>
CONFIG_CLEAN_FILES= version.h<br>
-AM_CFLAGS = @XORG_CFLAGS@ @LIBUDEV_CFLAGS@ @DRI_CFLAGS@<br>
+AM_CFLAGS = @XORG_CFLAGS@ @LIBUDEV_CFLAGS@ @DRI_CFLAGS@ -Werror<br>
openchrome_drv_la_LTLIBRARIES = <a href="http://openchrome_drv.la" rel="noreferrer" target="_blank">openchrome_drv.la</a><br>
openchrome_drv_la_LDFLAGS = -module -avoid-version @LIBUDEV_LIBS@<br>
openchrome_drv_ladir = @moduledir@/drivers<span><font color="#888888"><br>
-- <br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
Openchrome-devel mailing list<br>
<a href="mailto:Openchrome-devel@lists.freedesktop.org" target="_blank">Openchrome-devel@lists.freedes<wbr>ktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/openchrome-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/openchrome-de<wbr>vel</a><br>
</font></span></blockquote></div><br></div></div></div></div></div>
</blockquote></div><br></div>