[Openchrome-users] vt1625 and PAL modes?

[Xavier Bachelot]

Chad wrote:
> On 3/12/07, Xavier Bachelot <xavier at bachelot.org> wrote:
>> Stefan van der Eijk wrote:
>> > On 2/7/07, Xavier Bachelot <xb_ml at kelkoo.net> wrote:
>> >> Ken, I've made my own re-diff based on the patch on your page.
>> >> This are the 720x480Under, 720x480Fit and 720x480Over NTSC modes.
>> >> Could you please see if it matches your latest known good tries ?
>> >>
>> >> Regards,
>> >> Xavier
>> >
>> >
>> > Xavier, FYI: this patch doesn't compile with svn 303:
>> >
>> It never compiled with anything afaict :-) It's obviously missing a 
>> bracket.
>>
>> Here's a new version that actually compiles.
>>
>> Regards,
>> Xavier
> 
> This one still fails to compile for me.  At the top of the error I get:
> 
> gcc -DHAVE_CONFIG_H -I. -I. -I.. -DXFree86Server -DIN_MODULE 
> -DXFree86Module -D
> XFree86LOADER -I/usr/include/xorg -I/usr/include/drm -I/usr/include/drm 
> -I/usr/i
> nclude/X11/dri -g -O2 -MT via_vt162x.lo -MD -MP -MF .deps/via_vt162x.Tpo 
> -c via_
> vt162x.c  -fPIC -DPIC -o .libs/via_vt162x.o
> make[2]: Leaving directory `/tmp/openchrome/openchrome/unichrome'
> make[1]: Leaving directory `/tmp/openchrome/openchrome'
> ror: expected expression before '<<' token
> via_vt162x.h:874: error: initializer element is not constant
> via_vt162x.h:874: error: (near initialization for 'VT1625Table[5].TV1[0]')
> via_vt162x.h:894: warning: braces around scalar initializer
> via_vt162x.h:894: warning: (near initialization for 
> 'VT1625Table[5].TV1[2]')
> via_vt162x.h:894: warning: initialization makes integer from pointer 
> without a c
> ast
> via_vt162x.h:894: error: initializer element is not computable at load time
> via_vt162x.h:894: error: (near initialization for 'VT1625Table[5].TV1[2]')
> via_vt162x.h:894: warning: excess elements in scalar initializer
> via_vt162x.h:894: warning: (near initialization for 
> 'VT1625Table[5].TV1[2]')
> 
> At line 874 lives:
> <<<<<<< .mine
> 
> I'm quite lost in this area, but I'll look around.  If anyone has some
> ideas, I'm willing to play.  I'm just trying to compile this to see if
> there are improvements since the last time I patched using Ken's
> patches.  It was a while ago, so I'm hoping that maybe something other
> than 16bit 720x480Under (interlaced) is working for my NTSC setup.
> 
> -Chad

The patch was not applied properly.
remove unichrome/via_vt162x.h (or move it elsewhere if you modified it) 
then svn update and apply the patch again.

Regards,
Xavier