[Openchrome-users] out-of-bounds drawing by screensavers

[Thomas Hellström]

> Thomas Hellstr?m wrote:
>> OK, a possible fix checed in i SVN 294.
>
> Hi Thomas,
>
> Could you please explain how just moving this line:
>
>   sub = viaAccelClippingHelper(cb, (y1 < y2) ? y1 : y2, tdc);
>
> some 25 lines further up fixes the out-of-bounds drawing?  The sub
> variable doesn't get used in those 25 lines, nor do y1, y2, cb or
> tdc change in those lines.  How can simply moving this line affect
> the outcome?
>
> (And I've checked that it's just the moving of that line that
> fixes (most of) the faulty drawing, not the other change in the
> same commit.)
>
> Benno
>

It alters tdc->cmd, which is read a couple of lines later on.

/Thomas